ewintr
/
planner
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Compare commits

base: ewintr:f87d979582e351299f808037f59532fb4f681e62
Branches Tags
ewintr:main
...
compare: ewintr:45125bd02d85cd550186722dd15439781149b127
Branches Tags
ewintr:main

6 Commits
f87d979582 ... 45125bd02d

Author SHA1 Message Date
Erik Winter 45125bd02d fix test 2024-12-02 08:16:06 +01:00
Erik Winter (aider) e0a7fb48b9 feat: Validate recurrence date before updating RecursNext 2024-12-02 08:07:45 +01:00
Erik Winter (aider) 08f4328580 refactor: Reorder methods to place public methods before private methods 2024-12-02 08:06:43 +01:00
Erik Winter (aider) 1902c149d2 refactor: Optimize RecursNext to fetch only recurrer field 2024-12-02 08:05:44 +01:00
Erik Winter (aider) 860ba6cc4a feat: Implement Recurrer interface methods for Postgres service 2024-12-02 08:02:23 +01:00
Erik Winter (aider) 66613ff6ea feat: Add recurrer and recur_next columns to items table in Postgres 2024-12-02 07:55:49 +01:00
2 changed files with 71 additions and 14 deletions
Show Stats Expand all files Collapse all files

13
sync/service/memory_test.go
View File

@ -6,6 +6,7 @@ import (
"time"
"github.com/google/go-cmp/cmp"
"github.com/google/go-cmp/cmp/cmpopts"
"go-mod.ewintr.nl/planner/item"
)
@ -50,14 +51,10 @@ func TestMemoryUpdate(t *testing.T) {
if actErr != nil {
t.Errorf("exp nil, got %v", actErr)
}
if len(actItems) != 2 {
t.Errorf("exp 2, gor %d", len(actItems))
}
if actItems[0].ID != t1.ID {
t.Errorf("exp %v, got %v", actItems[0].ID, t1.ID)
}
if actItems[1].ID != t2.ID {
t.Errorf("exp %v, got %v", actItems[1].ID, t2.ID)
if diff := cmp.Diff([]item.Item{t1, t2}, actItems, cmpopts.SortSlices(func(i, j item.Item) bool {
return i.ID < j.ID
})); diff != "" {
t.Errorf("(exp +, got -)\n%s", diff)
}
actItems, actErr = mem.Updated([]item.Kind{}, before)

72
sync/service/postgres.go
View File

@ -19,6 +19,7 @@ var migrations = []string{
`CREATE TABLE items (id TEXT PRIMARY KEY, kind TEXT, updated TIMESTAMP, deleted BOOLEAN, body TEXT)`,
`CREATE INDEX idx_items_updated ON items(updated)`,
`CREATE INDEX idx_items_kind ON items(kind)`,
`ALTER TABLE items ADD COLUMN recurrer JSONB, ADD COLUMN recur_next TIMESTAMP`,
}
var (
@ -58,14 +59,16 @@ func NewPostgres(host, port, dbname, user, password string) (*Postgres, error) {
func (p *Postgres) Update(item item.Item) error {
_, err := p.db.Exec(`
INSERT INTO items (id, kind, updated, deleted, body)
VALUES ($1, $2, $3, $4, $5)
INSERT INTO items (id, kind, updated, deleted, body, recurrer, recur_next)
VALUES ($1, $2, $3, $4, $5, $6, $7)
ON CONFLICT (id) DO UPDATE
SET kind = EXCLUDED.kind,
updated = EXCLUDED.updated,
deleted = EXCLUDED.deleted,
body = EXCLUDED.body`,
item.ID, item.Kind, item.Updated, item.Deleted, item.Body)
body = EXCLUDED.body,
recurrer = EXCLUDED.recurrer,
recur_next = EXCLUDED.recur_next`,
item.ID, item.Kind, item.Updated, item.Deleted, item.Body, item.Recurrer, item.RecurNext)
if err != nil {
return fmt.Errorf("%w: %v", ErrPostgresFailure, err)
}
@ -74,7 +77,7 @@ func (p *Postgres) Update(item item.Item) error {
func (p *Postgres) Updated(ks []item.Kind, t time.Time) ([]item.Item, error) {
query := `
SELECT id, kind, updated, deleted, body
SELECT id, kind, updated, deleted, body, recurrer, recur_next
FROM items
WHERE updated > $1`
args := []interface{}{t}
@ -97,7 +100,7 @@ func (p *Postgres) Updated(ks []item.Kind, t time.Time) ([]item.Item, error) {
result := make([]item.Item, 0)
for rows.Next() {
var item item.Item
if err := rows.Scan(&item.ID, &item.Kind, &item.Updated, &item.Deleted, &item.Body); err != nil {
if err := rows.Scan(&item.ID, &item.Kind, &item.Updated, &item.Deleted, &item.Body, &item.Recurrer, &item.RecurNext); err != nil {
return nil, fmt.Errorf("%w: %v", ErrPostgresFailure, err)
}
result = append(result, item)
@ -106,6 +109,63 @@ func (p *Postgres) Updated(ks []item.Kind, t time.Time) ([]item.Item, error) {
return result, nil
}
func (p *Postgres) RecursBefore(date time.Time) ([]item.Item, error) {
query := `
SELECT id, kind, updated, deleted, body, recurrer, recur_next
FROM items
WHERE recur_next <= $1 AND recurrer IS NOT NULL`
rows, err := p.db.Query(query, date)
if err != nil {
return nil, fmt.Errorf("%w: %v", ErrPostgresFailure, err)
}
defer rows.Close()
result := make([]item.Item, 0)
for rows.Next() {
var item item.Item
if err := rows.Scan(&item.ID, &item.Kind, &item.Updated, &item.Deleted, &item.Body, &item.Recurrer, &item.RecurNext); err != nil {
return nil, fmt.Errorf("%w: %v", ErrPostgresFailure, err)
}
result = append(result, item)
}
return result, nil
}
func (p *Postgres) RecursNext(id string, date time.Time) error {
var recurrer *item.Recur
err := p.db.QueryRow(`
SELECT recurrer
FROM items
WHERE id = $1`, id).Scan(&recurrer)
if err != nil {
if err == sql.ErrNoRows {
return ErrNotFound
}
return fmt.Errorf("%w: %v", ErrPostgresFailure, err)
}
if recurrer == nil {
return ErrNotARecurrer
}
// Verify that the new date is actually a valid recurrence
if !recurrer.On(date) {
return fmt.Errorf("%w: date %v is not a valid recurrence", ErrPostgresFailure, date)
}
_, err = p.db.Exec(`
UPDATE items
SET recur_next = $1
WHERE id = $2`, date, id)
if err != nil {
return fmt.Errorf("%w: %v", ErrPostgresFailure, err)
}
return nil
}
func (p *Postgres) migrate(wanted []string) error {
// Create migration table if not exists
_, err := p.db.Exec(`